Conversation
|
I think this would be better via the CoderSDK upgrade. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
DataDog/dd-trace-go/v22.0.0 to 2.8.1. It's pulled in transitively bycodersdkthroughcoderd/tracing. govulncheck: 75 reachable to 72, fixing 3 (W3C baggage DoS and related).Behaviour change to review: dd-trace-go 2.8 calls
os.Setenv("_DD_ROOT_GO_SESSION_ID", <uuid>)at package init so child processes inherit it. envbuilder execs the workspace init process with its own environment, so this variable leaked into the workspace. That brokeTestPushImage/CompareBuiltAndCachedImageEnvironment, because the ID differs between the build and cached runs.options.UnsetEnvnow also clears_DD_ROOT_GO_SESSION_ID, next to the existingKANIKO_DIRcleanup.Part of a set of independent dependency PRs. All touch
go.mod/go.sum, so rebase withgo mod tidyafter the first one merges. The latest-Coder-SDK draft also pulls dd-trace-go 2.8 and includes the same fix.Generated by Coder Agents on behalf of @stirby.