Skip to content

chore: update example tests #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 22, 2021
Merged

chore: update example tests #174

merged 2 commits into from
Nov 22, 2021

Conversation

jawnsy
Copy link
Contributor

@jawnsy jawnsy commented Nov 22, 2021

Update tests for example values files to coalesce values using
the built-in Helm handling, rather than our custom rendering.
We should only use the struct-based rendering for unit tests.

Update tests for example values files to coalesce values using
the built-in Helm handling, rather than our custom rendering.
We should only use the struct-based rendering for unit tests.
@jawnsy jawnsy self-assigned this Nov 22, 2021
@jawnsy jawnsy marked this pull request as ready for review November 22, 2021 19:17
@jawnsy
Copy link
Contributor Author

jawnsy commented Nov 22, 2021

@jsjoeio This should unblock #166 once merged

Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray! This looks great 🚀

@jawnsy jawnsy merged commit 116a17e into main Nov 22, 2021
@jawnsy jawnsy deleted the jawnsy/chore-update-examples-test branch November 22, 2021 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants