Skip to content

feat: support --socket* options #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 15, 2025
Merged

Conversation

DanielleMaywood
Copy link
Collaborator

@DanielleMaywood DanielleMaywood commented Apr 14, 2025

Add new configuration options:

  • socket: Path to a socket.
  • socketMode: File mode of the socket when using the socket option.

I've also added a new job to the GitHub action's workflow to ensure the devcontainer feature documentation is up to date, as well as added a target to the makefile for generating the documentation.

@DanielleMaywood DanielleMaywood self-assigned this Apr 14, 2025
@DanielleMaywood DanielleMaywood changed the title feat: support '--socket*' options feat: support --socket* options Apr 14, 2025
@DanielleMaywood DanielleMaywood requested a review from Copilot April 14, 2025 22:55
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 9 changed files in this pull request and generated no comments.

Files not reviewed (7)
  • Makefile: Language not supported
  • scripts/check_unstaged.sh: Language not supported
  • src/code-server/devcontainer-feature.json: Language not supported
  • src/code-server/install.sh: Language not supported
  • test/code-server/code-server-socket-with-mode.sh: Language not supported
  • test/code-server/code-server-socket.sh: Language not supported
  • test/code-server/scenarios.json: Language not supported

@DanielleMaywood DanielleMaywood marked this pull request as ready for review April 14, 2025 22:57
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DanielleMaywood DanielleMaywood merged commit a926b94 into main Apr 15, 2025
8 checks passed
@DanielleMaywood DanielleMaywood deleted the dm-add-socket-options branch April 15, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants