fix: start coder connect progress indicator immediately #214
+54
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 4, 2025
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ethanndickson
force-pushed
the
ethan/validate-slim-binary-version
branch
from
ab9ca27 to
50e4a63
Compare
ethanndickson
force-pushed
the
ethan/progress-auto-start
branch
from
df10a17 to
60f8964
Compare
ethanndickson
force-pushed
the
ethan/progress-auto-start
branch
from
60f8964 to
acf0aeb
Compare
ethanndickson
force-pushed
the
ethan/validate-slim-binary-version
branch
from
50e4a63 to
8fb9382
Compare
ethanndickson
force-pushed
the
ethan/progress-auto-start
branch
from
acf0aeb to
f3468db
Compare
ethanndickson
force-pushed
the
ethan/validate-slim-binary-version
branch
from
8fb9382 to
431149f
Compare
deansheather
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the changes made in #203, it now takes a moment longer to receive the first progress update, when we either start the download (if not already downloaded), or validate the dylib. To address this, the progress indicator will immediately start making progress towards 25%. This prevents it from appearing stuck in what is an expected situation.
autoStartDemo.mov