feat: req/resp logging middleware #105
Open
+305
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
dannykopping
force-pushed
the
dk/request-logging-redux
branch
from
beb1aca to
d021c47
Compare
pawbana
reviewed
Jan 15, 2026
|
|
||
| return func(req *http.Request, next MiddlewareNext) (*http.Response, error) { | ||
| if err := d.dumpRequest(req); err != nil { | ||
| fmt.Fprintf(os.Stderr, "apidump: failed to dump request: %v\n", err) |
|
|
||
| resp, err := next(req) | ||
| if err != nil { | ||
| return resp, err |
Contributor
There was a problem hiding this comment.
Not sure about it but maybe it be useful to have "err" file with error?
| var bodyBytes []byte | ||
| if resp.Body != nil { | ||
| var err error | ||
| bodyBytes, err = io.ReadAll(resp.Body) |
Contributor
There was a problem hiding this comment.
This will make streaming non responsive. I assume this is fine since logging should generally not be enabled other then when debugging.
| func (i *interceptionBase) newCompletionsService(baseURL string, key string) openai.ChatCompletionService { | ||
| opts := []option.RequestOption{option.WithAPIKey(key), option.WithBaseURL(baseURL)} | ||
| func (i *interceptionBase) newCompletionsService() openai.ChatCompletionService { | ||
| opts := []option.RequestOption{option.WithAPIKey(i.cfg.Key), option.WithBaseURL(i.cfg.BaseURL)} |
Contributor
There was a problem hiding this comment.
nit: indent
opts := []option.RequestOption{
option.WithAPIKey(i.cfg.Key),
option.WithBaseURL(i.cfg.BaseURL),
}
| interceptor = responses.NewStreamingInterceptor(id, &req, payload, p.cfg.BaseURL, p.cfg.Key, string(req.Model)) | ||
| } else { | ||
| interceptor = responses.NewBlockingInterceptor(id, &req, payload, p.baseURL, p.key, string(req.Model)) | ||
| interceptor = responses.NewBlockingInterceptor(id, &req, payload, p.cfg.BaseURL, p.cfg.Key, string(req.Model)) |
Contributor
There was a problem hiding this comment.
apidump could be added to responses interceptor as well
| name: config.ProviderOpenAI, | ||
| fixture: fixtures.OaiChatSimple, | ||
| providerName: config.ProviderOpenAI, | ||
| configureFunc: func(addr, dumpDir string, client aibridge.Recorder) (*aibridge.RequestBridge, error) { |
Contributor
There was a problem hiding this comment.
I think inlined configureFunc with provider as a test param would be easier to understand
| reqDumpData, err := os.ReadFile(reqDumpFile) | ||
| require.NoError(t, err, "request dump file should exist") | ||
| require.Contains(t, string(reqDumpData), "POST ") | ||
| require.Contains(t, string(reqDumpData), "Host:") |
Contributor
There was a problem hiding this comment.
maybe add check like require.Contains(t, string(reqDumpData), string(reqBody))
and similar for response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logs the raw HTTP requests to and responses from AI providers' APIs.
$ tree /tmp/anthropic/ /tmp/anthropic/ ├── claude-haiku-4-5-20251001 │ ├── bb8e4048-8ea2-4aee-a58d-25027b962bf8.req.txt │ ├── bb8e4048-8ea2-4aee-a58d-25027b962bf8.resp.txt │ ├── e1f338a1-7ae9-4ccf-b898-fc3fbc25124e.req.txt │ └── e1f338a1-7ae9-4ccf-b898-fc3fbc25124e.resp.txt └── claude-opus-4-5-20251101 ├── 024f344e-c75a-46ea-abfb-e45e117e121a.req.txt ├── 024f344e-c75a-46ea-abfb-e45e117e121a.resp.txt ├── 0f02d1f5-882d-474f-b83d-85f09fd63ded.req.txt ├── 0f02d1f5-882d-474f-b83d-85f09fd63ded.resp.txt ├── 7f80f624-bf0b-4c12-a521-8c7654febe5d.req.txt ├── 7f80f624-bf0b-4c12-a521-8c7654febe5d.resp.txt ├── b9a37e54-1cd2-4a4f-92aa-c9adff088f4e.req.txt └── b9a37e54-1cd2-4a4f-92aa-c9adff088f4e.resp.txt