-
Couldn't load subscription status.
- Fork 11
Moved examples from Python SDK documentation #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| @@ -0,0 +1,41 @@ | |||
| from immudb import ImmudbClient | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
references samples may be under it's own folder? or in secondary indexes?
| @@ -0,0 +1,43 @@ | |||
|
|
|||
| from grpc import RpcError | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should split the samples, not only for python but in the other languages as well, regarding deprecated login/logout and managed sessions
but we may do that change in another PR
|
|
||
| # Managed session support | ||
| with client.openManagedSession(LOGIN, PASSWORD, database=DB) as session: | ||
| transaction = session.newTx() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for login/logout there were no actions, here it's executing sql stmts, we may keep just the session handling?
| PASSWORD = "immudb" # Default password | ||
| DB = b"defaultdb" # Default database name (must be in bytes) | ||
|
|
||
| def main(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this sample doesn't correspond to getAtTx but to getTxById
also, I'm curious about the get api, how it's differentiating from getAtRevision... in java sdk even with param overloading it was better to have a dedicated method get, getAtRevision, getAtTx ...
No description provided.