Skip to content

Conversation

@Razikus
Copy link

@Razikus Razikus commented Jun 12, 2022

No description provided.

@Razikus Razikus requested a review from tomekkolo June 13, 2022 07:42
@tomekkolo tomekkolo requested review from byo and jeroiraz June 13, 2022 17:26
@@ -0,0 +1,41 @@
from immudb import ImmudbClient
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

references samples may be under it's own folder? or in secondary indexes?

@@ -0,0 +1,43 @@

from grpc import RpcError
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should split the samples, not only for python but in the other languages as well, regarding deprecated login/logout and managed sessions

but we may do that change in another PR


# Managed session support
with client.openManagedSession(LOGIN, PASSWORD, database=DB) as session:
transaction = session.newTx()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for login/logout there were no actions, here it's executing sql stmts, we may keep just the session handling?

PASSWORD = "immudb" # Default password
DB = b"defaultdb" # Default database name (must be in bytes)

def main():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this sample doesn't correspond to getAtTx but to getTxById

also, I'm curious about the get api, how it's differentiating from getAtRevision... in java sdk even with param overloading it was better to have a dedicated method get, getAtRevision, getAtTx ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants