Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use jsonld lib for import #32

Merged
merged 3 commits into from
Mar 28, 2024
Merged

Use jsonld lib for import #32

merged 3 commits into from
Mar 28, 2024

Conversation

hjonin
Copy link
Contributor

@hjonin hjonin commented Mar 19, 2024

Resolves #25

progval
progval reviewed Mar 19, 2024
View reviewed changes
Copy link
Member

@progval progval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test to check that we actually support new forms of the same documents? For example, that we can now load documents in fully expanded form.

js/validation/index.js Outdated Show resolved Hide resolved
hjonin added 2 commits March 19, 2024 12:27
@hjonin
Remove unnecessary code
dff9c58
@hjonin
Add test
82f41d6 
Import expanded document version
@hjonin
Copy link
Contributor Author

hjonin commented Mar 21, 2024

WIP fix expanded URLs in the test

@hjonin
Copy link
Contributor Author

hjonin commented Mar 21, 2024

Ignore previous message, URL was correct

@progval progval mentioned this pull request Mar 28, 2024
Closed
@progval
Copy link
Member

progval commented Mar 28, 2024

Is this PR ready for merge?

@hjonin
Copy link
Contributor Author

hjonin commented Mar 28, 2024

Yes, sorry I forgot to precise!

@progval progval merged commit 858cc4e into codemeta:master Mar 28, 2024
1 check passed
@hjonin hjonin deleted the feat/gh-25-jsonldjs-import branch May 7, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@progval progval progval left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to jsonld.js to load and dump documents
2 participants
@hjonin @progval