Skip to content

Conversation

@malucky
Copy link

@malucky malucky commented Dec 13, 2019

The original reported issue is that HTML is auto-folded.
But as of this PR, the observed behavior is that nothing
is auto-folded.

Changes:

  • configure Monaco setting to folding: true - fixes all
    use cases of
  • add autoFold directive to uses

The original reported issue is that HTML is auto-folded.
But as of this PR, the observed behavior is that nothing
is auto-folded.

Changes:
- configure Monaco setting to `folding: true` - fixes all
  use cases of <code-demo-multitab-editor>
- add `autoFold` directive to <code-demo-editor> uses
@malucky
Copy link
Author

malucky commented Dec 13, 2019

alternative to adding autoFolding directive to all instances of <code-demo-editor> is https://github.com/codelab-fun/codelab/compare/master...malucky:auto-folding-alternative?expand=1

But I don't have confidence this alternative won't break something else

@kirjs
Copy link
Collaborator

kirjs commented Dec 16, 2019

Hey, thanks for looking into this.

ideally code-demo is a generic component which could be used outside of the codelab, so the first option is preferable.

I think one way to avoid redundancy would be later create a codelab-specific wrapper that would enable autofolding, but I think for now this would be good to be merged as it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants