chore: bump mssql image to 2025#9987
Open
paulbalandan wants to merge 2 commits intocodeigniter4:developfrom
Open
chore: bump mssql image to 2025#9987paulbalandan wants to merge 2 commits intocodeigniter4:developfrom
paulbalandan wants to merge 2 commits intocodeigniter4:developfrom
Conversation
85bec24 to
f3f2aa0
Compare
Member
Author
|
I am stumped at why SQLSRV fails for only PHP 8.2 to 8.4 but not 8.5. |
f3f2aa0 to
bea379d
Compare
bea379d to
f4dba7b
Compare
Member
|
PHP 8.5 is failing too. I guess we still allow it to fail without consequences. Hmm... something had to change in connection state tracking in the new version of mssql. Based on this: https://stackoverflow.com/questions/7469130/cannot-drop-database-because-it-is-currently-in-use We can try adding this to public function dropDatabase(string $dbName): bool
{
try {
$this->db->query(sprintf(
'ALTER DATABASE %s SET SINGLE_USER WITH ROLLBACK IMMEDIATE',
$this->db->escapeIdentifier($dbName),
));
} catch (DatabaseException) {}
return parent::dropDatabase($dbName);
} |
Co-authored-by: michalsn <michal@sniatala.pl>
Member
Author
|
Thanks. I saw that StackOverflow post earlier and did not realize that was the solution. 🤦♂️ |
michalsn
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This tries to fix #9980 by bumping mssql image to 2025 and using the latest ubuntu runner.
Checklist: