Skip to content

refactor: remove redundant property declarations in BaseController #9659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2025
Merged

refactor: remove redundant property declarations in BaseController #9659

merged 1 commit into from
Aug 5, 2025

Conversation

paulbalandan
Copy link
Member

Description
These are already declared by Controller

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added the refactor Pull requests that refactor code label Aug 2, 2025
samsonasik
samsonasik reviewed Aug 2, 2025
View reviewed changes
@paulbalandan paulbalandan force-pushed the duplicate-property-dec branch from cef0e94 to cb3225e Compare August 4, 2025 12:56
@paulbalandan paulbalandan merged commit f0ba124 into codeigniter4:develop Aug 5, 2025
49 checks passed
@paulbalandan paulbalandan deleted the duplicate-property-dec branch August 5, 2025 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik left review comments

@michalsn michalsn michalsn approved these changes

@datamweb datamweb datamweb approved these changes

@neznaika0 neznaika0 neznaika0 approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@paulbalandan @michalsn @samsonasik @datamweb @neznaika0