Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add info about Router::getMatchedRouteOptions() #9441

Merged
merged 2 commits into from
Feb 7, 2025
Merged

docs: Add info about Router::getMatchedRouteOptions() #9441

merged 2 commits into from
Feb 7, 2025

Conversation

neznaika0
Copy link
Contributor

Description

  • Added information about the method

https://forum.codeigniter.com/showthread.php?tid=88747

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

michalsn
michalsn reviewed Feb 5, 2025
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some suggestions and changes to make the code example a little more realistic.

user_guide_src/source/incoming/routing.rst Outdated Show resolved Hide resolved
user_guide_src/source/incoming/routing/074.php Outdated Show resolved Hide resolved
user_guide_src/source/incoming/routing/074.php Outdated Show resolved Hide resolved
@neznaika0
Copy link
Contributor Author

@michalsn thanks, changed

michalsn
michalsn approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@michalsn michalsn added the documentation Pull requests for documentation only label Feb 5, 2025
datamweb
datamweb approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@paulbalandan paulbalandan merged commit efcabb3 into codeigniter4:develop Feb 7, 2025
9 checks passed
@neznaika0 neznaika0 deleted the docs/add-router-note branch February 7, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@datamweb datamweb datamweb approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
documentation Pull requests for documentation only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@neznaika0 @michalsn @datamweb @paulbalandan