For Windows OS, revert the usage of cmd.exe by default #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very good, I'd even go so far and drop the same stuff for Unix. Never understood why one has to invoke |
Why not, but out of scope of this pull request IMO, designed to fix the |
|
Correct. |
|
@axel3rd Please fix the conflicts. Thanks. |
|
See #41, usage of a shell wrapper is not really a relevant behavior => closing |
|
See #110 for following. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf. #17 (comments from May 2018): Revert the usage of
cmd.exeby default (on Windows), because prevents the destroy/kill launched by this way whenCTRL+C.Allow this behavior by the usage of a new method:
This PR should be chosen or #41.