Skip to content

Fix SCM URLs #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Fix SCM URLs #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,12 @@
<description>This library provides encryption/decryption functionality with pluggable ciphers and password providers</description>

<scm>
<connection>scm:git:git@github.com:codehaus-plexus/plexus-sec-dispatcher.git</connection>
<developerConnection>scm:git:[email protected]:codehaus-plexus/plexus-sec-dispatcher.git</developerConnection>
<connection>scm:git:https://github.com/codehaus-plexus/plexus-sec-dispatcher.git</connection>
<developerConnection>scm:git:ssh://[email protected]:codehaus-plexus/plexus-sec-dispatcher.git</developerConnection>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we use SSH or HTTPs authentication here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see https in more of plexus project

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is IMHO a hassle with GitHub as it requires using PAT (https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/about-authentication-to-github#https).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make it work with SSH as before, as HTTPS is meh. I have same issue on ASF projects as well, HTTPS gitbox keeps asking me for username and pw, unlike when using SSH.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were some concerns in the past regarding blocked SSH ports. For me there is a fundamental difference between Gitbox and GitHub: The former allows to use your regular credentials, the latter requires a PAT.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to change start from - parent pom .... mixed can have impact of relative path calculation by site plugin 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer the case with an upcoming version of maven-site-plugin: apache/maven-site-plugin#227

<tag>HEAD</tag>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HEAD is ok value here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 3d4acb7.

<url>https://github.com/codehaus-plexus/plexus-sec-dispatcher.git</url>
<url>https://github.com/codehaus-plexus/plexus-sec-dispatcher/tree/${project.scm.tag}/</url>
</scm>

<issueManagement>
<system>jira</system>
<url>https://github.com/codehaus-plexus/plexus-sec-dispatcher/issues</url>
Expand Down
Loading