Skip to content

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 3, 2024

Bumps org.eclipse.jdt:ecj from 3.38.0 to 3.40.0.

Commits

Most Recent Ignore Conditions Applied to This Pull Request
Dependency Name Ignore Conditions
org.eclipse.jdt:ecj [>= 3.34.a, < 3.35]
org.eclipse.jdt:ecj [>= 3.35.a, < 3.36]

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Dec 3, 2024
@slachiewicz
Copy link
Member

@dependabot ignore this dependency

@dependabot dependabot bot closed this Dec 14, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 14, 2024

OK, I won't notify you about org.eclipse.jdt:ecj again, unless you re-open this PR.

@dependabot dependabot bot deleted the dependabot/maven/org.eclipse.jdt-ecj-3.40.0 branch December 14, 2024 19:58
@pzygielo
Copy link
Contributor

ignore this dependency

Is there a plan to drop support for eclipse compiler?

@slachiewicz slachiewicz restored the dependabot/maven/org.eclipse.jdt-ecj-3.40.0 branch December 25, 2024 21:45
@slachiewicz slachiewicz reopened this Dec 25, 2024
@slachiewicz
Copy link
Member

@dependabot rebase

Bumps [org.eclipse.jdt:ecj](https://github.com/eclipse-jdt/eclipse.jdt.core) from 3.38.0 to 3.40.0.
- [Commits](https://github.com/eclipse-jdt/eclipse.jdt.core/commits)

---
updated-dependencies:
- dependency-name: org.eclipse.jdt:ecj
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/maven/org.eclipse.jdt-ecj-3.40.0 branch from ddb9344 to 70343c3 Compare December 25, 2024 21:46
@slachiewicz
Copy link
Member

No. I we will still have ECJ here.
So far build fails with error

EcjFailureException: Failed to run the ecj compiler: source level should be in '1.8','9'...'22' (or '8.0'..'22.0'): 1.3

@pzygielo
Copy link
Contributor

pzygielo commented Dec 25, 2024

I guess this contributes to the error:

But there are some other problems reported once this is changed.

I believe it should be updated to 1.8 anyway, regardless of this bump.

@slachiewicz slachiewicz merged commit 6950ab9 into master Dec 26, 2024
65 checks passed
@slachiewicz slachiewicz deleted the dependabot/maven/org.eclipse.jdt-ecj-3.40.0 branch December 26, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants