Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Spotless formatting by default build #45

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Copy link
Member

@slachiewicz slachiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this not the default?

Copy link
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be done in parent pom.
please look at Maven parent.

@ascheman
Copy link
Author

ascheman commented Mar 19, 2025

If it was active by default, the GH action builds of the mentioned projects should have failed, right?
The parent POM uses the check in a particular profile (format-check), which is activated when the CI environment variable is set.

Should I change the PR to set this environment variable or perhaps to activate the Maven profile?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants