Skip to content

Fix - Tabs component #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix - Tabs component #446

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1dd871
fixed initial selectedTabIndex on Tabs
enguerranws Sep 12, 2025
ae2e642
fixed initial selectedTabIndex on Tabs
enguerranws Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 3 additions & 20 deletions src/Tabs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,6 @@
"use client";

import React, {
memo,
forwardRef,
useId,
useState,
useEffect,
type ReactNode,
type CSSProperties
} from "react";
import React, { memo, forwardRef, useId, type ReactNode, type CSSProperties, useMemo } from "react";
import type { FrIconClassName, RiIconClassName } from "./fr/generatedFromCss/classNames";
import { symToStr } from "tsafe/symToStr";
import { fr } from "./fr";
Expand Down Expand Up @@ -78,24 +70,15 @@ export const Tabs = memo(
"explicitlyProvidedId": id_props
});

const getSelectedTabIndex = () => {
const selectedTabIndex = useMemo(() => {
const index = tabs.findIndex(tab =>
"content" in tab ? tab.isDefault ?? false : tab.tabId === selectedTabId
);
return index === -1 ? 0 : index;
};
}, [tabs, selectedTabId]);

const buttonRefs = React.useRef<Array<HTMLButtonElement | null>>([]);

const [selectedTabIndex, setSelectedTabIndex] = useState<number>(getSelectedTabIndex);

useEffect(() => {
if (selectedTabId === undefined) {
return;
}
setSelectedTabIndex(getSelectedTabIndex());
}, [selectedTabId]);

const onTabClickFactory = useCallbackFactory(([tabIndex]: [number]) => {
if (selectedTabId === undefined) {
onTabChange?.({
Expand Down