Skip to content

Export Link type in Summary.tsx #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

pprev94
Copy link
Contributor

@pprev94 pprev94 commented Jun 12, 2025

For convenience, export the link type from Summary.tsx

@ddecrulle
Copy link
Collaborator

ddecrulle commented Jun 12, 2025

Hello,

There are several Link types in the library, so we can’t export the one from Summary as-is without risking naming conflicts. One option would be to use a namespace and expose it as SummaryProps.Link, but that feels a bit heavy for this use case. Alternatively, we could export the type under a different name, such as SummaryLink, if you prefer having a named type.

In the meantime, I recommend using SummaryProps["links"][number], which is simple and effective.

Let me know what you think!

@pprev94
Copy link
Contributor Author

pprev94 commented Jun 12, 2025

You're right, Link is a too common word and can be a source of conflicts.

Thanks

@ddecrulle ddecrulle closed this Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants