Iteration over pictograms #425
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #424 and the comments made by @ddecrulle in #417.
It includes :
The pictogram components now follows this structure:
I've added new examples to the storybook such as color variation.
Also, I edited the import section and replaced it with an individual import:
import { Accessibility } from "@codegouvfr/react-dsfr/picto";
=>import Accessibility from "@codegouvfr/react-dsfr/picto/Accessibility";
Sorry for the back and forth, I had started this implementation for a project and it was enough but I should have thought about reading the DSFR specs on the subject better before proposing my first PR, we would have saved time :)