Skip to content

Pictograms documentation #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 6, 2025

Conversation

Maxenceee
Copy link
Contributor

@Maxenceee Maxenceee commented Jun 3, 2025

Here is my proposal for the documentation of the feature added in PR #417 and resolve #419

It contains a new page allowing you to search for picto and some examples.

Screenshot from 2025-06-03 20-08-10

Screenshot from 2025-06-03 20-08-21

@Maxenceee Maxenceee changed the title Resolves #419 Resolves codegouvfr/react-dsfr#419 Jun 3, 2025
@Maxenceee Maxenceee changed the title Resolves codegouvfr/react-dsfr#419 resolves codegouvfr/react-dsfr#419 Jun 3, 2025
@Maxenceee Maxenceee changed the title resolves codegouvfr/react-dsfr#419 resolves #419 Jun 3, 2025
@Maxenceee Maxenceee changed the title resolves #419 Pictograms documentation Jun 3, 2025
@ddecrulle
Copy link
Collaborator

Thanks a lot for this contribution, it looks great and will be very helpful to the community!

@ddecrulle ddecrulle merged commit 320fd62 into codegouvfr:main Jun 6, 2025
6 checks passed
@garronej
Copy link
Collaborator

garronej commented Jun 6, 2025

@Maxenceee I'm genuinely impressed.
This is truly a high-value contribution!

Thoroughly appreciated — sorry for not merging it sooner.

@garronej
Copy link
Collaborator

garronej commented Jun 6, 2025

image

It is a bit sad that the pictogram aren't dark mode ready but I think this is on the DSFR team to not have created dark mode variant.

@Maxenceee
Copy link
Contributor Author

@garronej Yes, I noticed it too. But the DSFR has no specification for dark mode.

If you want, I can trick to reverse the color and use white instead of dark blue, but I'm not sure it would be really appreciated and useful.

@Maxenceee Maxenceee deleted the feature/pictogrammes-storybook branch June 6, 2025 12:15
@ddecrulle
Copy link
Collaborator

ddecrulle commented Jun 6, 2025

@garronej Yes, I noticed it too. But the DSFR has no specification for dark mode.

The pictogram uses CSS variables that automatically adapt to light or dark mode, so no specific dark mode implementation is needed.
I think your implementation might be breaking this behavior.

Live examples or provided here

@Maxenceee
Copy link
Contributor Author

Okay i will change that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ajout de la documentation suite à #417
3 participants