Improve 'Cron (timer) triggers' page #1319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Deleted the 'Seconds' field from the 'Cron Expression Fields' table, as we support only five fields in the cron expression. 2. Moved 'Predefined Scheduling for Cron Jobs' and 'Fixed Interval Scheduling for Cron Jobs' to the 'Cron Triggers with Codefresh CLI' section (relevant only for legacy cron triggers), since our UI no longer supports them. Additionally, these schedules use six fields in the cron expression, which has been deprecated.
Updating the screenshot in the 'Create a Cron Trigger in UI' section (How-To, Step 5) to reflect the current support for five-field cron expressions in the UI. The previous screenshot incorrectly displays six fields.
|
"[CI] Staging environment is at http://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/maryiaCodefesh-dev-cron-triggers/docs/" |
Removed 'Predefined Scheduling for Cron Jobs' and 'Fixed Interval Scheduling for Cron Jobs' sections
|
"[CI] Staging environment is at http://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/maryiaCodefesh-dev-cron-triggers/docs/" |
|
Closing the PR after merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we support five-field cron expressions instead of six, I suggest the following improvements in addition to CR-23870.
Delete the 'Seconds' field from the 'Cron Expression Fields' table, as we support only five fields in the cron expression.
Move 'Predefined Scheduling for Cron Jobs' and 'Fixed Interval Scheduling for Cron Jobs' to the 'Cron Triggers with Codefresh CLI' section (relevant only for legacy cron triggers), since our UI no longer supports them. Additionally, these schedules use six fields in the cron expression, which has been deprecated.
Update the screenshot in the 'Create a Cron Trigger in UI' section (How-To, Step 5) to reflect the current support for five-field cron expressions in the UI. The previous screenshot incorrectly displays six fields.