Skip to content

fix: doc for onprem 2.7 #1317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

fix: doc for onprem 2.7 #1317

wants to merge 6 commits into from

Conversation

vasil-cf
Copy link
Contributor

@vasil-cf vasil-cf commented May 14, 2025

@vasil-cf vasil-cf requested a review from mikhail-klimko May 14, 2025 11:05
@vasil-cf vasil-cf requested a review from NimRegev as a code owner May 14, 2025 11:05
@codefresh-git-integration
Copy link

Restructured to make it clear
@codefresh-git-integration
Copy link

@codefresh-git-integration
Copy link

@codefresh-git-integration
Copy link

@vasil-cf vasil-cf requested a review from masontikhonov May 15, 2025 08:12
@codefresh-git-integration
Copy link

Copy link
Contributor Author

@vasil-cf vasil-cf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


#### Installing v2.7
For detailed instructions on installing v2.7, visit [ArtifactHub](https://artifacthub.io/packages/helm/codefresh-onprem/codefresh){:target="\_blank"}.

#### Upgrading to v2.7
For details, see [Upgrade to 2.7 in ArtifactHub](https://artifacthub.io/packages/helm/codefresh-onprem/codefresh#to-2-7-0){:target="\_blank"}

**New indexes**
We added a new `feature-store-versioned` collection which requires **two new indexes** for good performance.
You must create the indexes listed below _**right after** upgrading_ to prevent disruption and avoid performance issues.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikhail-klimko @masontikhonov
_**right after** upgrading_ is this right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be on a safe side I would say “before or right after”.

We could extend explanation to clarify that if created before upgrade, collection should be created first:

use codefresh;
db.createCollection('feature-store-versioned');

```json
{
"expireAfterSeconds" : 43200
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikhail-klimko @masontikhonov
I omitted the following properties (as it was done for indexes for other versions in our documentation):

{
    "v" : 2,
    "name" : "createdAt_1",
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is correct, the only option matter is expireAfterSeconds


`createdAt_1` (db: `codefresh`; collection: `feature-store-versioned`)

* **Index details**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* **Index details**
* **Index keys**

"createdAt" : 1
}
```
* **Index properties**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* **Index properties**
* **Index options**


`LDRedisStoreVersion_1__id_-1` (db: `codefresh`; collection: `feature-store-versioned`)

* **Index details**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* **Index details**
* **Index keys**

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants