-
Notifications
You must be signed in to change notification settings - Fork 163
fix: doc for onprem 2.7 #1317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: doc for onprem 2.7 #1317
Conversation
"[CI] Staging environment is at http://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/fix-onprem-2.7-indexes/docs/" |
Restructured to make it clear
"[CI] Staging environment is at http://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/fix-onprem-2.7-indexes/docs/" |
"[CI] Staging environment is at http://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/fix-onprem-2.7-indexes/docs/" |
"[CI] Staging environment is at http://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/fix-onprem-2.7-indexes/docs/" |
"[CI] Staging environment is at http://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/fix-onprem-2.7-indexes/docs/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikhail-klimko @masontikhonov please check
|
||
#### Installing v2.7 | ||
For detailed instructions on installing v2.7, visit [ArtifactHub](https://artifacthub.io/packages/helm/codefresh-onprem/codefresh){:target="\_blank"}. | ||
|
||
#### Upgrading to v2.7 | ||
For details, see [Upgrade to 2.7 in ArtifactHub](https://artifacthub.io/packages/helm/codefresh-onprem/codefresh#to-2-7-0){:target="\_blank"} | ||
|
||
**New indexes** | ||
We added a new `feature-store-versioned` collection which requires **two new indexes** for good performance. | ||
You must create the indexes listed below _**right after** upgrading_ to prevent disruption and avoid performance issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikhail-klimko @masontikhonov
_**right after** upgrading_
is this right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be on a safe side I would say “before or right after”.
We could extend explanation to clarify that if created before upgrade, collection should be created first:
use codefresh;
db.createCollection('feature-store-versioned');
```json | ||
{ | ||
"expireAfterSeconds" : 43200 | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikhail-klimko @masontikhonov
I omitted the following properties (as it was done for indexes for other versions in our documentation):
{
"v" : 2,
"name" : "createdAt_1",
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is correct, the only option matter is expireAfterSeconds
|
||
`createdAt_1` (db: `codefresh`; collection: `feature-store-versioned`) | ||
|
||
* **Index details** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* **Index details** | |
* **Index keys** |
"createdAt" : 1 | ||
} | ||
``` | ||
* **Index properties** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* **Index properties** | |
* **Index options** |
|
||
`LDRedisStoreVersion_1__id_-1` (db: `codefresh`; collection: `feature-store-versioned`) | ||
|
||
* **Index details** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* **Index details** | |
* **Index keys** |
https://codefresh-io.atlassian.net/browse/CR-29062