Skip to content

fix: fix debugger #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025
Merged

fix: fix debugger #25

merged 1 commit into from
May 12, 2025

Conversation

masontikhonov
Copy link
Contributor

@masontikhonov masontikhonov commented May 6, 2025

What

This fixes debugger by partially reverting changes from #24:

  • bash is required as it is an entry-point for the spawned shell;
  • removal of mc is a breaking change;
  • changing base image is a breaking change as it have different set of bound tools, so the existing customer script may broke.

This also resizes terminal to fit window during initial launch; and provides tip on how to resize it again if needed.

Notes

Labels

Assign the following labels to the PR:

security - to trigger image scanning in CI build

PR Comments

Add the following comments to the PR:

/e2e - to trigger E2E build

@masontikhonov masontikhonov self-assigned this May 6, 2025
@masontikhonov masontikhonov force-pushed the CR-28812-debugger branch 3 times, most recently from 0511830 to 9ed0a4b Compare May 6, 2025 20:49
@masontikhonov masontikhonov marked this pull request as ready for review May 7, 2025 21:27
@masontikhonov
Copy link
Contributor Author

/e2e

@masontikhonov masontikhonov merged commit 1c815d4 into master May 12, 2025
4 checks passed
@masontikhonov masontikhonov deleted the CR-28812-debugger branch May 12, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants