Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add second slider to AgeSlider component for choosing retirement month #230

Merged
merged 8 commits into from
Nov 11, 2020

Conversation

dmeegan
Copy link
Collaborator

@dmeegan dmeegan commented Oct 12, 2020

This pull request:

  1. Adds a second slider for choosing the desired retirement month.
  2. Revisises calculations to change on setting both desired year(age) and month(age) of retirement.
  3. Disables the month slider and sets the desired month in the calculation to zero when retirement age is set to 70.

Is progress on issue #115

dmeegan added 2 commits October 11, 2020 19:11
…set to 70

2. Disable month slider when retirement age year is set to 70
@thadk
Copy link
Member

thadk commented Oct 13, 2020

Can you please add ticks to the slider so Zero says January, 6 says June and 11 says December? I did this for FRA in the original slider, so you can use that as an example.

@dmeegan
Copy link
Collaborator Author

dmeegan commented Oct 21, 2020

As of my latest commit at 11 on 11-20, the slider still needs to be worked on. Currently, it automatically sets the months to 0 or 1 based on 62 or 70 years old, however, the month stays at that age when switching to other years.

@thadk thadk merged commit 55c4733 into codeforboston:develop Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants