Repository navigation
Fix Jest Tests - #2329
Merged
Merged
Fix Jest Tests#2329
Conversation
…s for most tests. For some tests that require emulators, moving them to run under integration tests where they belong. Still need to resolve skipped tests in useEditTestimony.test.ts and hooks.tests.ts
…tests making real API calls
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Mephistic
requested review from
alexjball,
kiminkim724,
mvictor55,
nesanders and
timblais
as code owners
November 1, 2026 00:01
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses an issue raised in the Conference Committee work where we found that many of our unit tests weren't running in CI. This re-enables those tests, moves tests that require the emulator to run under the Integration Test runner, and fixes broken tests. All jest tests in the main web project now pass.
This also includes a change I'm testing in CI to add a network guard to our jest runner - this would prevent any external network calls from
jest. I'm testing this now to see if this interferes with the integration tests in CI - if it does, I'll drop back to a simpler change to ensure theNEXT_PUBLIC_PROJECT_ID_FOR_TESTis overridden so it does not point to the real DEV environment. (This is useful for local development since it lets you quickly point your local frontend at a deployed backend - but we don't want that for unit tests).