Repository navigation
Conversation
…e API signature for now, will address in a follow-up commit after confirming parity with the full system.
…ies/Tags. Still need to reconfigure jest to run tests in scripts folder
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 task
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a second attempt at moving the currently running Python-based LLM bill summary/tag generation into TypeScript (to avoid maintaining a second Firebase deploy pipeline for one function) - the older PR had some parity issues based around tokenization, so this one focuses on matching the existing behavior exactly.
Open issues for a follow-up PR include:
maple-llmcodebase fromfirebase.json4o-minito a more recent model (likely a Google-developed one, given the rest of our infra is already on Google Cloud)Deploy Notes
OPENAI_API_KEYFirebase Functions Secret on DEV and PRODOPENAI_DEVandOPENAI_PROD, and can delete those older secrets once the new ones are livebill_on_document_createdfunction (to avoid double processing)