Revert "[1753] Replace custom routing with react-instantsearch-router-nextjs" #1898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mephistic
requested review from
sashamaryl,
mertbagt,
nesanders,
mvictor55,
timblais,
alexjball and
kiminkim724
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1766
Looks like some additions we've made to the Search Filters since that PR was originally approved don't play nicely with this change (specifically, merging this breaks the search filters in the mobile view) - going to revert this for now to restore those additions we'll dig in at hack night to see how to better integrate this change and get better automated testing around search going forward (specifically, we need to make sure that the automated tests also check the mobile view).