Email template update #1806
Merged
Email template update #1806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mertbagt
requested review from
sashamaryl,
nesanders,
mvictor55,
timblais,
alexjball,
Mephistic and
kiminkim724
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Mephistic
approved these changes
Apr 25, 2025
| @@ -22,6 +22,15 @@ export function isDefined(v: unknown) { | |||
| return v !== undefined | |||
| } | |||
|
|
|||
| export function formatDate(timestamp: Date) { | |||
There was a problem hiding this comment.
Not a blocker, but did timestamp.toLocaleDateString() not do the trick (e.g. for today, it should print out 4/24/2025). No complaints if this works.
There was a problem hiding this comment.
I needed to initialize the timestamp first, but yea that works and it's more consise
OOC, what user data do we need? Is there extra data we need to provide in the digest for rendering, or are you just talking about hooking this up to real data? |
|
I should have said user 'feedback' in terms of the css potentially getting weird on different email apps/browsers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
switched image links to absolute links at mapletestimony
modified the date formatting
Checklist
Screenshots
Known issues
email generates NaN for dates, but works fine with storybook
probably the differences in the test data
empty envelope image used for No Updates included in this PR
image won't be broken once it gets to prod
gmail can do wierd things to the css,
in the long term, need user data
various tiny details like bar length can be polished/fine tuned
Steps to test/reproduce
For each feature or bug fix, create a step by step list for how a reviewer can test it out. E.g.: