Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CCAP-734] Create New submit-contact-provider-email-confirmation screen #1343

Merged
merged 12 commits into from
Apr 1, 2025
Merged

[CCAP-734] Create New submit-contact-provider-email-confirmation screen #1343

merged 12 commits into from
Apr 1, 2025

Conversation

enyia21
Copy link
Contributor

@enyia21 enyia21 commented Mar 27, 2025 •
edited
Loading

🔗 Jira ticket

CCAP-734

✍️ Description

Modifies submit-contact-provider-email-confirmation-screen
  • Adds the appropriate title, header and email body.
  • Adds methods to the Date Utilities class to get the month day and time values for the email message.
  • Adds unit tests for the DateUtilities class methods that were added
  • Update JourneyTest for the new screen

📷 Design reference

Figma

⚠️ Button label differs from figma because the implementation that changes the button label is on a future ticket. ⚠️

Figma
image

PR
image

✅ Completion tasks

  • Added relevant tests
  • Meets acceptance criteria

@enyia21 enyia21 temporarily deployed to il-gcc-ccap-734-create--gzxwtn March 27, 2025 17:15 Inactive
@enyia21 enyia21 temporarily deployed to il-gcc-ccap-734-create--gzxwtn March 27, 2025 17:49 Inactive
@enyia21 enyia21 temporarily deployed to il-gcc-ccap-734-create--gzxwtn March 27, 2025 18:04 Inactive
@enyia21 enyia21 marked this pull request as ready for review March 27, 2025 18:10
@enyia21 enyia21 requested review from spokenbird and analoo and removed request for analoo March 27, 2025 18:10
@enyia21 enyia21 added Ready For Review Merge After Acceptance Pull requests should not be merge until acceptance testing has been completed on PR labels Mar 27, 2025
@enyia21 enyia21 requested review from analoo and removed request for spokenbird March 28, 2025 16:30
analoo
analoo reviewed Mar 28, 2025
View reviewed changes
src/test/java/org/ilgcc/app/journeys/GccProviderMessagingFlowJourneyTest.java Outdated
// submit-contact-provider-email-confirmation
testPage.navigateToFlowScreen("gcc/submit-contact-provider-email-confirmation");
assertThat(testPage.getTitle()).isEqualTo(getEnMessage("submit-contact-provider-email-confirmation.title"));
assertThat(testPage.getHeader()).isEqualTo(getEnMessage("submit-contact-provider-email-confirmation.header"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need to check the header, just the title.

analoo
analoo reviewed Mar 28, 2025
View reviewed changes
src/main/resources/application-dev.yaml Outdated
@@ -30,5 +30,6 @@ org:
retry-back-off-time-seed: 1
il-gcc:
enable-emails: ${ENABLE_EMAILS_FLAG:false}
enable-provider-messaging: ${ENABLE_PROVIDER_MESSAGING:false}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this since it is already defined in heroku

@enyia21 enyia21 temporarily deployed to il-gcc-ccap-734-create--gzxwtn March 28, 2025 17:17 Inactive
@enyia21 enyia21 temporarily deployed to il-gcc-ccap-734-create--gzxwtn March 28, 2025 18:23 Inactive
@enyia21 enyia21 temporarily deployed to il-gcc-ccap-734-create--gzxwtn March 28, 2025 18:29 Inactive
@enyia21 enyia21 temporarily deployed to il-gcc-ccap-734-create--gzxwtn March 28, 2025 22:09 Inactive
analoo
analoo approved these changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@analoo analoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking for submittedAt and if you chose to change it, you can merge/move to acceptance testing as soon as you are done.

cram-cfa
cram-cfa requested changes Mar 31, 2025
View reviewed changes
Copy link
Contributor

@cram-cfa cram-cfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure the name of this PR properly references the Jira ticket, so the release notes are correct. Thanks!

@enyia21 enyia21 changed the title Ccap 734 Create New submit-contact-provider-email-confirmation screen CCAP-734 Create New submit-contact-provider-email-confirmation screen Mar 31, 2025
@enyia21 enyia21 changed the title CCAP-734 Create New submit-contact-provider-email-confirmation screen [CCAP-734] Create New submit-contact-provider-email-confirmation screen Mar 31, 2025
@enyia21 enyia21 temporarily deployed to il-gcc-ccap-734-create--gzxwtn March 31, 2025 20:22 Inactive
enyia21 and others added 10 commits March 31, 2025 15:28
@enyia21
[CCAP-734] Update submit-contact-provider-email-confirmation.html screen
95de8db
@enyia21
[CCAP-734] Added helper methods to get month day and time from submit…
ff79c35 
…tedAt.
@enyia21
[CCAP-734] Passes values into submit-contact-provider-email-confirmat…
a81d5dc 
…ion.html fragment
@enyia21
[CCAP-734] Added tests for helper methods added to DateUtilities and …
87b7de0 
…Updated relevant journey test
@enyia21
[CCAP-734] changed note over submit-contact-provider-email-confirmati…
3d9d7d2 
…on screen and turned enable-provider-messaging off on dev
@enyia21 @analoo
Update src/main/resources/messages.properties
a3eaac0 
Co-authored-by: Ana Medrano Fernandez <[email protected]>
@enyia21
Update GccProviderMessagingFlowJourneyTest.java
d88cb20 
Removed Header test
@enyia21
Update application-dev.yaml
4bcb725 
Removed email flag change
@enyia21
[CCAP-735] Remove DateUtilities methods corresponding tests
4af2d6a
@enyia21
[CCAP-734] Updates text to read screen elements correctly and fixes c…
77072e1 
…opy to match designs
@enyia21 enyia21 force-pushed the CCAP-734-Create-new-submit-contact-provider-email-confirmation-screen branch from a83d158 to 77072e1 Compare March 31, 2025 20:38
@enyia21 enyia21 temporarily deployed to il-gcc-ccap-734-create--gzxwtn March 31, 2025 20:39 Inactive
@enyia21 enyia21 requested a review from cram-cfa March 31, 2025 20:39
@enyia21 enyia21 merged commit c813768 into main Apr 1, 2025
5 checks passed
@enyia21 enyia21 deleted the CCAP-734-Create-new-submit-contact-provider-email-confirmation-screen branch April 1, 2025 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@analoo analoo analoo approved these changes

@cram-cfa cram-cfa Awaiting requested review from cram-cfa

Assignees

@enyia21 enyia21

Labels
Merge After Acceptance Pull requests should not be merge until acceptance testing has been completed on PR Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@enyia21 @analoo @cram-cfa