Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop items are not necessarily deep copied #294

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Drop items are not necessarily deep copied #294

wants to merge 3 commits into from

Conversation

damrem
Copy link

@damrem damrem commented Oct 11, 2016 •
edited
Loading

Issue #143 had been closed, but items still were deep copied even when settings were specifying not to do so.

@codef0rmer
Copy link
Owner

@damrem Thanks man..! Can you add a unit test?

@damrem
Copy link
Author

damrem commented Oct 12, 2016

@codef0rmer Sure! I should find some time soon.

@damrem
Copy link
Author

damrem commented Nov 29, 2016

Hey, I've finally added tests.

@codef0rmer
Copy link
Owner

codef0rmer commented Dec 4, 2016 •
edited
Loading

@damrem Thanks for adding tests. I noticed that the direction animation breaks by not using deepCopy by default in https://github.com/codef0rmer/angular-dragdrop/blob/master/demo/dnd-insertInline.html.

I do not remember If I intentionally left it to be deep copied for animation to work. Did you face any problem with that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@damrem @codef0rmer