Skip to content

Account of file size OS rounding in image max size #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HanCotterell merged 1 commit into from
Dec 3, 2025
Merged

Account of file size OS rounding in image max size #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/scripts/validate-pr.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ async function run() {
{
name: "Check image file size",
test: async ({ data, imageFiles }) => {
const MAX_SIZE = 200 * 1024; // 200 KB
const MAX_SIZE = 250000; // 250 KB (some leeway for OS rounding)
const imageFile = imageFiles.find(f => f.filename === data.image);

if (!imageFile) return false;
Expand Down
Loading