Skip to content

fix: some flakes #3830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 2, 2025
Merged

fix: some flakes #3830

merged 9 commits into from
Apr 2, 2025

Conversation

spalmurray
Copy link
Contributor

@spalmurray spalmurray commented Apr 1, 2025 •
edited
Loading

Fixes a few flakes. There are probably more but CI has passed twice in a row.

@spalmurray spalmurray changed the title spalmurray/flake sadge draft: flakes Apr 1, 2025
@codecov-staging
Copy link

codecov-staging bot commented Apr 1, 2025 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 22 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system 6.11MB 11 bytes (0.0%) ⬆️
gazebo-staging-esm 6.19MB 11 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-staging-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js 11 bytes 12.03kB 0.09%

Files in assets/index-legacy.*.js:

  • ./src/pages/MembersPage/MembersActivation/MembersActivation.jsx → Total Size: 1.35kB
view changes for bundle: gazebo-staging-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js 11 bytes 12.56kB 0.09%

Files in assets/index.*.js:

  • ./src/pages/MembersPage/MembersActivation/MembersActivation.jsx → Total Size: 1.35kB

@codecov Codecov
Copy link

codecov bot commented Apr 1, 2025 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 22 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.11MB 11 bytes (0.0%) ⬆️
gazebo-production-esm 6.19MB 11 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-production-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js 11 bytes 12.56kB 0.09%

Files in assets/index.*.js:

  • ./src/pages/MembersPage/MembersActivation/MembersActivation.jsx → Total Size: 1.35kB
view changes for bundle: gazebo-production-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js 11 bytes 12.03kB 0.09%

Files in assets/index-legacy.*.js:

  • ./src/pages/MembersPage/MembersActivation/MembersActivation.jsx → Total Size: 1.35kB

@codecov Codecov
Copy link

codecov bot commented Apr 1, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.72%. Comparing base (819dcd9) to head (93b29ff).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3830      +/-   ##
==========================================
- Coverage   98.73%   98.72%   -0.01%     
==========================================
  Files         827      827              
  Lines       14996    15000       +4     
  Branches     4286     4281       -5     
==========================================
+ Hits        14806    14809       +3     
- Misses        183      184       +1     
  Partials        7        7
Files with missing lines Coverage Δ
...embersPage/MembersActivation/MembersActivation.jsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.28% <100.00%> (-0.02%) ⬇️
Services 99.35% <ø> (ø)
Shared 99.11% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 819dcd9...93b29ff. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Apr 1, 2025 •
edited by codecov-notifications bot
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3830      +/-   ##
==========================================
- Coverage   98.73%   98.72%   -0.01%     
==========================================
  Files         827      827              
  Lines       14996    15000       +4     
  Branches     4286     4289       +3     
==========================================
+ Hits        14806    14809       +3     
- Misses        183      184       +1     
  Partials        7        7
Files with missing lines Coverage Δ
...embersPage/MembersActivation/MembersActivation.jsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.28% <100.00%> (-0.02%) ⬇️
Services 99.35% <ø> (ø)
Shared 99.11% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 819dcd9...93b29ff. Read the comment docs.

@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented Apr 1, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.72%. Comparing base (819dcd9) to head (93b29ff).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3830      +/-   ##
==========================================
- Coverage   98.73%   98.72%   -0.01%     
==========================================
  Files         827      827              
  Lines       14996    15000       +4     
  Branches     4278     4281       +3     
==========================================
+ Hits        14806    14809       +3     
- Misses        183      184       +1     
  Partials        7        7
Files with missing lines Coverage Δ
...embersPage/MembersActivation/MembersActivation.jsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.28% <100.00%> (-0.02%) ⬇️
Services 99.35% <ø> (ø)
Shared 99.11% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 819dcd9...93b29ff. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Apr 1, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.72%. Comparing base (819dcd9) to head (93b29ff).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3830      +/-   ##
==========================================
- Coverage   98.73%   98.72%   -0.01%     
==========================================
  Files         827      827              
  Lines       14996    15000       +4     
  Branches     4278     4281       +3     
==========================================
+ Hits        14806    14809       +3     
- Misses        183      184       +1     
  Partials        7        7
Files with missing lines Coverage Δ
...embersPage/MembersActivation/MembersActivation.jsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.28% <100.00%> (-0.02%) ⬇️
Services 99.35% <ø> (ø)
Shared 99.11% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 819dcd9...93b29ff. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Apr 1, 2025 •
edited
Loading

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
80826ba Tue, 01 Apr 2025 20:53:07 GMT Expired Expired
623777c Tue, 01 Apr 2025 20:56:12 GMT Expired Expired
623777c Tue, 01 Apr 2025 21:01:08 GMT Expired Expired
b95be8c Tue, 01 Apr 2025 21:06:35 GMT Expired Expired
a70c664 Tue, 01 Apr 2025 21:14:40 GMT Expired Expired
a2cf3fa Tue, 01 Apr 2025 21:21:24 GMT Expired Expired
80826ba Wed, 02 Apr 2025 17:49:34 GMT Expired Expired
69170a8 Wed, 02 Apr 2025 18:22:43 GMT Expired Expired
d7ec30a Wed, 02 Apr 2025 18:28:40 GMT Expired Expired
ff540d8 Wed, 02 Apr 2025 18:37:52 GMT Expired Expired
ff540d8 Wed, 02 Apr 2025 18:42:23 GMT Expired Expired
1689e24 Wed, 02 Apr 2025 18:58:55 GMT Expired Expired
7d48ceb Wed, 02 Apr 2025 20:58:57 GMT Expired Expired
c01e709 Wed, 02 Apr 2025 21:54:25 GMT Expired Expired
93b29ff Wed, 02 Apr 2025 22:00:17 GMT Cloud Enterprise

@spalmurray spalmurray force-pushed the spalmurray/flake-sadge branch 2 times, most recently from 69170a8 to d7ec30a Compare April 2, 2025 18:22
@spalmurray spalmurray changed the title draft: flakes fix: some flakes Apr 2, 2025
@spalmurray spalmurray marked this pull request as ready for review April 2, 2025 18:30
@spalmurray spalmurray force-pushed the spalmurray/flake-sadge branch from 1689e24 to 7d48ceb Compare April 2, 2025 20:53
suejung-sentry
suejung-sentry approved these changes Apr 2, 2025
View reviewed changes
Copy link
Contributor

@suejung-sentry suejung-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oof nice finds - sadge indeed. thanks so much for doing this!

@spalmurray spalmurray added this pull request to the merge queue Apr 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 2, 2025
@spalmurray spalmurray added this pull request to the merge queue Apr 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 2, 2025
@spalmurray spalmurray added this pull request to the merge queue Apr 2, 2025
Merged via the queue into main with commit 3e120ca Apr 2, 2025
58 of 63 checks passed
@spalmurray spalmurray deleted the spalmurray/flake-sadge branch April 2, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suejung-sentry suejung-sentry suejung-sentry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spalmurray @codecov-releaser @suejung-sentry