This repository was archived by the owner on Jul 16, 2025. It is now read-only.
feat: upload TA even when a file is not found#585
Merged
joseph-sentry merged 4 commits intomainfrom Feb 12, 2025
Merged
Conversation
❌ 5 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
|
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
we only want to ingest a string from the cli options as click doesn't support enums yet "internally" we only want to use this enum
if the report_type is "test_results" and we don't find any files to upload we want to send a request to the regular test results endpoint with "file_not_found" set to True and not expect a raw_upload_location in the response
052ac3c to
7a58082
Compare
Swatinem
previously approved these changes
Jan 31, 2025
Swatinem
approved these changes
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on this API change being shipped: codecov/codecov-api#1075