move tryTo, retryTo to effects #4743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavertMik
requested changes
Jan 13, 2025
Contributor
DavertMik
left a comment
DavertMik
left a comment
There was a problem hiding this comment.
hopeThat should either be removed or re-implemented to not be the same as tryTo
hopeThat can store failures inside test.notes (additional listener needed) and raise an error if error has appeared
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
tryTo,retryTotoeffectshopeThatApplicable helpers:
Applicable plugins:
Type of change
Checklist:
npm run docs)npm run lint)npm test)