This repository was archived by the owner on Jul 17, 2026. It is now read-only.
use MD5 password hasher under test - #130
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #130 +/- ##
=======================================
Coverage 76.33% 76.33%
=======================================
Files 28 28
Lines 393 393
=======================================
Hits 300 300
Misses 93 93 Continue to review full report at Codecov.
|
lpatmo
approved these changes
Apr 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This restores the optimisation I removed in #109 to get the tests working.
Now that we're using Factories rather than fixtures, we can use what we want under test.
A good production password hashing algorithm is slow by design and hard to optimise. This makes it difficult to brute-force. The reason cookiecutter suggests this is because MD5 is not very secure but it is fast to calculate. We don't care about security of data we generate while running tests, but we do want it to be fast to build, so using a known vulnerable hash algorithm makes sense here. Its a bit of a micro-optimisation, but its definitely not going to make the tests run any slower, so we might as well re-enable it now.