Multiple changes #39

fpapadopou · 2015-08-21T10:14:07Z

ChangeLog

Replaces Fixing SensioLabs' Insight warnings to improve the quality of the code #17 and Fixes deletion Actions' big size #19 originally authored by @tzikis and reviewed by @spiliot (fixes all issues that came up during the review process)
Adds proper Travis CI configuration for PHP 5.3, 5.4, 5.5
Revamps the (functional) tests. Adds test cases for external cores/variants.
Adds code that removes all weird paths from linker errors and a related functional test.
Includes Parameters cleanup #34 which revises the parameters.yml file.
Adds code that removes the userId_cb_personal_lib from the compiler error output

It is good practice not to use it with Symfony, and this project is small enought that it's unnecessary

Made a strict boolean check for the return value of the Header Preprocessing function

These Controller actions are much bigger than they should be, and so the main logic should go to a Handler. Initial implementation for the 1st one (untelsted)

Moved code to DeletionHandler Service

If the object files dir wasn't opened, opendir echoes a Warning (probably depends on PHP settings), which would break our JSON. Fixed that

…etionaction-fixes Had to completely remove the composer.lock file and run composer update

Removed unused parameters from config file

… Symfony by composer)

…unnecessary logs)

…ction-fixes Changes in compiler cached objects deletetion Actions (Sensiolabs)

…tput

…ilation output and added info texts, indicating where the error came from

fpapadopou · 2015-08-28T12:40:14Z

Done here. Already merged with current master branch and gets coverage up to 63%.

fpapadopou · 2015-08-28T12:41:23Z

Will checkout this branch on staging server in order to use it through the next week(s) before merging.

…ation

…xpected)

fpapadopou · 2015-10-12T15:01:40Z

@spiliot please review this PR, add the correct flags when done

fpapadopou · 2015-10-23T15:18:06Z

Added hold because this PR contains code ( dbaa56d, 1dbc0d0 and 2fa9595 ) that properly handles HTML file contents (to be added)

Php 5.5.9 ubuntu 14.04 (based on #39)

tzikis added 30 commits January 9, 2015 02:06

Removed in_memory Security Providers (unused)

6e07cd5

Replaced OR operator with || & explicit precedence

0f56ce5

Removed unnecessary __FILE__ variables

8a30ae3

It is good practice not to use it with Symfony, and this project is small enought that it's unnecessary

Added codebender favicon

9aeed6c

Added stricter checks for successful extractions

e25959f

Added stricter checks for successful preprocessing

b332d4a

Made a strict boolean check for the return value of the Header Preprocessing function

Deleted Acme Bundle (Symfony2 Demo)

7aa2d68

Fixed Error due to removal of Acme Bundle

cf132dd

Fixed 2nd Error due to removal of Acme Bundle

01ee571

This should fix the Acme deletion error

7057acc

Removed dead code

ae8fab2

Added 1 more strict bool check

885857c

Renamed a variable for readability

13f9500

This should fix all missing ending newlines

ec1d2b7

Auto-Formated PreprocessingHandler

29eab63

Auto-Formated UtilityHandler

0ee4557

Auto-Formated PostProcessingHandler

8c57183

Auto-Formated MCUHandler

21854c0

Auto-Formated DefaultController

d25ee5a

Silenced PHPStorm Warning

4260afd

Auto-Formated DefaultControllerTest

ff13752

Removed unused Class

65d426f

Auto-Formated CompilerHandler

8b0faee

Avoiding using functions in for loop

b52fc76

Fixed all PSR-1 Method Naming warnings (hopefuly)

c1b4154

Initial fix for containing the deletion Actions

d42172c

These Controller actions are much bigger than they should be, and so the main logic should go to a Handler. Initial implementation for the 1st one (untelsted)

Fixed 2nd deletion Action size

af91913

Moved code to DeletionHandler Service

Updated Symfony version and dependencies

95f8e21

Suppressed Warning that breaks our JSON output

1334b87

If the object files dir wasn't opened, opendir echoes a Warning (probably depends on PHP settings), which would break our JSON. Fixed that

Added EOF Newline

9af22c7

fpapadopou and others added 6 commits July 24, 2015 12:43

Merge remote-tracking branch 'origin/dev' into sensiolabs-insight-del…

15a46f9

…etionaction-fixes Had to completely remove the composer.lock file and run composer update

Merge pull request #36 from codebendercc/parameters-revision

e431319

Removed unused parameters from config file

Removed update coveralls statement (it's already installed along with…

756fce4

… Symfony by composer)

Silenced arduino core file unzipping (produces more than 7K lines of …

b05358d

…unnecessary logs)

Merge pull request #35 from codebendercc/sensiolabs-insight-deletiona…

290356e

…ction-fixes Changes in compiler cached objects deletetion Actions (Sensiolabs)

Merge remote-tracking branch 'origin/dev' into travis

5fd92ab

fpapadopou added the WIP label Aug 21, 2015

fpapadopou added 3 commits August 21, 2015 15:15

Added coded that removes unnecessary paths info from linking error ou…

1b07b90

…tput

Code formatting in tests class

ab69a71

Added functional test for the linker output cleanup function

5a7c0ba

spiliot added the Reviewed label Aug 21, 2015

fpapadopou added 2 commits August 28, 2015 15:26

Removed 'files', 'libraries', 'cb_personal_libraries' paths from comp…

3e2b0e9

…ilation output and added info texts, indicating where the error came from

Merge remote-tracking branch 'origin/master' into dev

7c226ff

fpapadopou added Ready for review and removed Reviewed labels Aug 28, 2015

fpapadopou added 4 commits September 2, 2015 13:22

Removed '$' from class parameters usages in DeletionHandler

e48b6fe

Decode HTML entities in project files and library files before compil…

2fa9595

…ation

Added a test for html encoded input to the compiler

1dbc0d0

Updated test and html encoding-decoding code (didn't really work as e…

dbaa56d

…xpected)

fpapadopou removed the WIP label Oct 12, 2015

spiliot added Reviewed and removed Ready for review labels Oct 21, 2015

fpapadopou added Hold and removed Reviewed labels Oct 23, 2015

spiliot merged commit dbaa56d into master Nov 15, 2015

spiliot added a commit that referenced this pull request Nov 15, 2015

Merge pull request #42 from codebendercc/php_5.5.9-ubuntu_14.04

faaad43

Php 5.5.9 ubuntu 14.04 (based on #39)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Multiple changes #39

Multiple changes #39

fpapadopou commented Aug 21, 2015

fpapadopou commented Aug 28, 2015

fpapadopou commented Aug 28, 2015

fpapadopou commented Oct 12, 2015

fpapadopou commented Oct 23, 2015

Multiple changes #39

Multiple changes #39

Conversation

fpapadopou commented Aug 21, 2015

ChangeLog

fpapadopou commented Aug 28, 2015

fpapadopou commented Aug 28, 2015

fpapadopou commented Oct 12, 2015

fpapadopou commented Oct 23, 2015