refactor: inline Permissions concern into Member#2703
Open
mroderick wants to merge 1 commit into
Open
Conversation
Permissions was a single-model concern only included in Member, making it a code-slicing concern rather than a shared behavioral extraction. Inlined its rolify call and 4 instance methods (organiser?, admin_or_organiser?, monthlies_organiser?, organised_chapters) directly into Member. - Removed app/models/concerns/permissions.rb - Updated spec to reference Member instead of Permissions module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Permissionswas a single-model concern (app/models/concerns/permissions.rb) only included inMember— a code-slicing concern rather than a shared behavioral extraction per layered architecture principles.Solution
Inline the
rolifycall and 4 instance methods (organiser?,admin_or_organiser?,monthlies_organiser?,organised_chapters) directly intoMember. Delete the concern file.The spec was updated from
RSpec.describe PermissionstoRSpec.describe Memberand renamed fromspec/models/concerns/permissions_spec.rbtospec/models/member_permissions_spec.rb.Verification