New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): dockrize the application #698

Open

MAVRICK-1 wants to merge 1 commit into codeaashu:main from MAVRICK-1:main

MAVRICK-1 commented Jan 1, 2025

Description

This PR introduces a Dockerfile with a multistage build for better performance and optimized image size. The Dockerfile separates the build environment from the runtime environment, ensuring a cleaner and more efficient Docker image.

Related Issues

Fixes #694

Changes Proposed

Added a multistage Dockerfile to separate the build and runtime environments.
The first stage uses a Node.js base image for installing dependencies and building the application.
The second stage copies only the necessary files from the build stage and uses a lighter base image (e.g., nginx) for serving the application.

Here is the Dockerfile structure:

# Build Stage
FROM node:16 AS build

WORKDIR /app

COPY package*.json ./
RUN npm install

COPY . .

RUN npm run build

# Production Stage
FROM nginx:alpine

COPY --from=build /app/dist /usr/share/nginx/html

EXPOSE 80
CMD ["nginx", "-g", "daemon off;"]

Checklist

I have read and followed the [Contribution Guidelines](https://github.com/codeaashu/DevDisplay/blob/master/CONTRIBUTING.md).
All new and existing tests passed successfully.
I have updated the documentation to reflect the changes made in this PR.
My code adheres to the code style and formatting guidelines of this project.
The title of my pull request is concise and describes the change being proposed.

Screenshots

Notes for Reviewers

Please review the changes related to the Docker multistage build. The idea is to ensure that the production image is optimized and that we are only copying the necessary files to the final image.


          feat(cli): dockrize the application

9baa888

stackblitz bot commented Jan 1, 2025

Run & review this pull request in StackBlitz Codeflow.

vercel bot commented Jan 1, 2025 •

edited

Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
devdisplay	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 1, 2025 6:04pm

Author

MAVRICK-1 commented Jan 1, 2025

@colemanscott98 review my PR and add the labels

vercel bot deployed to Preview

January 1, 2025 18:04

View deployment

github-actions bot commented Mar 2, 2025

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

21 similar comments

github-actions bot commented Mar 3, 2025

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

github-actions bot commented Mar 4, 2025

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

github-actions bot commented Mar 5, 2025

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

github-actions bot commented Mar 6, 2025

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

github-actions bot commented Mar 7, 2025

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

github-actions bot commented Mar 8, 2025

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

github-actions bot commented Mar 9, 2025

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

github-actions bot commented Mar 10, 2025

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

github-actions bot commented Mar 11, 2025

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

github-actions bot commented Mar 12, 2025

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

github-actions bot commented Mar 13, 2025

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

github-actions bot commented Mar 14, 2025

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

github-actions bot commented Mar 15, 2025

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

github-actions bot commented Mar 16, 2025

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

github-actions bot commented Mar 17, 2025

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

github-actions bot commented Mar 18, 2025

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

github-actions bot commented Mar 19, 2025

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

github-actions bot commented Mar 20, 2025

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

github-actions bot commented Mar 21, 2025

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

github-actions bot commented Mar 22, 2025

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

github-actions bot commented Mar 23, 2025

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet