Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mentor commands can be used by those with mentor roles #14

Merged
merged 3 commits into from
Nov 28, 2020
Merged

Mentor commands can be used by those with mentor roles #14

merged 3 commits into from
Nov 28, 2020

Conversation

skyegallup
Copy link
Collaborator

Closes #5

@skyegallup skyegallup changed the base branch from main to develop November 10, 2020 22:28
@skyegallup
Copy link
Collaborator Author

Only question I have here is that $showqueue should probably be a mentor-only command, since it contains sensitive information (discussed in #7). Should that change be made in this PR, or in the future PR for #7?

@skyegallup skyegallup requested a review from peterkos November 21, 2020 02:28
This was referenced Nov 22, 2020
Closed
Open
@skyegallup skyegallup merged commit b152bfb into develop Nov 28, 2020
@skyegallup skyegallup deleted the issue-5 branch November 28, 2020 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterkos peterkos peterkos approved these changes

@Madrugaur Madrugaur Awaiting requested review from Madrugaur

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restrict mentor commands to roles instead of admin
2 participants
@skyegallup @peterkos