BrickHack 8 Site - About Section #1254
Conversation
|
rip netlify 😔 |
| .card { | ||
| width: 100%; | ||
|
|
||
| &:not(.card:last-of-type) { |
There was a problem hiding this comment.
Removing it makes the two cards press up against each other with no space between them.
|
One thing we can tackle later is the extra padding in the right card due to less content compared to the left card. Can prob fix with some filler text |
See design's Figma. That is specified.
See design's Figma. That is specified. Moving it up would push it to flex-start and create a ton of whitespace underneath.
Last update I made to number styling was doing the code in front of design team and asking what they liked. They specifically approved what is in there now. If there are issues to be had with what design team is specifying, I recommend pinging them about it in #design channel. I am inclined to go with whatever they say.
Not really sure what you mean here. It would be something to bring up with marketing in the general pr. Generally, we should want our content to be concise for ux/skimming purposes, not verbose for aesthetic purposes. |
|
Apologies for being a bit out of the loop; as with the numbers changing from the figma, I wasn't 100% on if the spacing was also as intentional.
Yea, that's what I mean -- would be good to talk w/ Adam on adding some filler as an alternative to modifying the design itself LGTM |
|
I agree with @sjmiller7 that it's not a great idea to add unnecessary or unnecessarily verbose text just to eliminate whitespace. Content > styling |
* swapping files and start gutting bh7 copy * more gutting of css * style refactor * logo update * design fixes * mobile navbar * design fixes * social cards being funky * editing social card resolution * adjusting social card * favicon swap * nav underline * outline color fix * remove login * fixes * comment fixes * contact first attempt * changing social links * Revert "comment fixes" This reverts commit 75f57c6. * Revert "Revert "comment fixes"" This reverts commit 6c75a58. * Revert "changing social links" This reverts commit fef9a7b. * Revert "contact first attempt" This reverts commit d980e9a. * BrickHack 8 Site - Hero Section (#1253) * starting hero * hero section * swapping out loop file * fixes * design fixes * spacing fix * BrickHack 8 Site - About Section (#1254) * inital about section * card width * fixes * BrickHack 8 Site - FAQ Section (#1252) * faq styling + ricky * fixing mobile * removing old padding class * fixes * fixing broken cards * BrickHack 8 Site - Contact & Footer (#1256) * contact section * fixes * newline eof Co-authored-by: Skye Gallup <[email protected]> * fixing aspect ratio code Co-authored-by: Skye Gallup <[email protected]> * design + js fixes * design fixes * trying to hide play button * trying to hide play button 2 * trying to hide play button 3 * fixing faq ricky * fixing mobile grayout opacity * hiding mlh banner * copyright date * updating stats * prepping for open applications * content fixes for chris * spelling error Co-authored-by: Chris Baudouin, Jr. <[email protected]> * fixing spelling error * fixing faq padding * hero content adjustments * hero content addition * centering hero on mobile Co-authored-by: Skye Gallup <[email protected]> Co-authored-by: Chris Baudouin, Jr. <[email protected]>
Fixes #1248
Had to remove prizes cards since we technically don't know if we have prizes yet.
At the time of posting, I am waiting on Design to fix the bar underneath the rickies. I might talk to them Monday (12/6) about switching to gifs for quality, since the video here is also fuzzy. Might need to do some analysis of gif file size vs quality upgrade.