BrickHack 8 Site - Hero Section #1253
Conversation
There was a problem hiding this comment.
One nit, one mobile issue commented in code.
Another general nit: Sun God Ricky leaves a trail of flaming text in his wake The landing video slightly clips the content at some viewport widths. I know this is a very hard problem to deal with though, and it'll probably need to get changed anyway once design team returns with a margin-less video file, so it's not a big complaint - feel free to ignore this.
Going to ask Design about changing this layout a bit.
This will be going away as I swap it out for login and signup buttons. Going to do that and fixes probably tomorrow |
|
I don't feel great about the hero. Something is still a bit off in its transition to mobile but I can't tell how to fix it. I don't want the text to wrap on the content bit but I'm having trouble getting it to balance with the video. Might be something with flex grow/shrink I'm missing that could fix it? It also feels like the video is HUGE when I swap to mobile... I could cut down the width maybe and give it more space on the sides? Or trying to bring down the point where I swap it from row to column? Lmk what you all think Leaving out login and register buttons in the navbar until the general pr. |
|
Did some fixes based on critique from design team. At this point, I just want to merge it in so design can actually see any further changes at a preview link-- that will take out a lot of the struggle we are dealing with for blocking right now. So as long as there's no code issues right now, I suggest we save design nits for main branch and go ahead and merge everything. |
|
I know it's super buggy and ugly right now, I am not happy with it. I really just want design to look and have the final say, which is tough to do through screenshots and over discord with communication at the pace it currently is. Again, if we have no big code problems in this and the other prs I say we just merge. I can probably look at merging Monday evening (12/20) |
|
Don't know why I can't comment directly on this comment:
When the notif for that comment appeared in my inbox, it showed you were commenting on old code that still had the mailing form. Can you double check? |
no, I commented on the latest version, I think |
|
LGTM |
* swapping files and start gutting bh7 copy * more gutting of css * style refactor * logo update * design fixes * mobile navbar * design fixes * social cards being funky * editing social card resolution * adjusting social card * favicon swap * nav underline * outline color fix * remove login * fixes * comment fixes * contact first attempt * changing social links * Revert "comment fixes" This reverts commit 75f57c6. * Revert "Revert "comment fixes"" This reverts commit 6c75a58. * Revert "changing social links" This reverts commit fef9a7b. * Revert "contact first attempt" This reverts commit d980e9a. * BrickHack 8 Site - Hero Section (#1253) * starting hero * hero section * swapping out loop file * fixes * design fixes * spacing fix * BrickHack 8 Site - About Section (#1254) * inital about section * card width * fixes * BrickHack 8 Site - FAQ Section (#1252) * faq styling + ricky * fixing mobile * removing old padding class * fixes * fixing broken cards * BrickHack 8 Site - Contact & Footer (#1256) * contact section * fixes * newline eof Co-authored-by: Skye Gallup <[email protected]> * fixing aspect ratio code Co-authored-by: Skye Gallup <[email protected]> * design + js fixes * design fixes * trying to hide play button * trying to hide play button 2 * trying to hide play button 3 * fixing faq ricky * fixing mobile grayout opacity * hiding mlh banner * copyright date * updating stats * prepping for open applications * content fixes for chris * spelling error Co-authored-by: Chris Baudouin, Jr. <[email protected]> * fixing spelling error * fixing faq padding * hero content adjustments * hero content addition * centering hero on mobile Co-authored-by: Skye Gallup <[email protected]> Co-authored-by: Chris Baudouin, Jr. <[email protected]>
Fixes #1247
Need to check with Design on breakpoints and handling mobile. This Ricky has a lot of spacing on him and I want to make sure he looks alright.