[pull] canary from vercel:canary#790
Merged
pull[bot] merged 14 commits intocode:canaryfrom Feb 14, 2026
Merged
Conversation
These were being filtered unexpectedly causing build failures with the deferredEntries flag. x-ref: [slack thread](https://vercel.slack.com/archives/C09125LC4AX/p1771010370849309?thread_ts=1770975846.539109&cid=C09125LC4AX)
…items (#89874) _I wrote this PR by hand, because I wanted to make sure I got all the details right._ The previous approach for computing global names was `module path` + `item name`. Since @lukesandberg added support for inventory, we can now nest `turbo_task::function` and `turbo_task::value` macros inside any arbitrary scope:  This is a fantastic feature, but it does mean that our global names are no longer unique. @mmastrac suggested using `std::any::type_name` with a dummy marker type to get a full path. This PR attempts to do that.
finding the file with sync IO utils is tricky because it is called `utils`. this change gives the file a more clear name.
…#89964) Tiny optimization, there is no need to use global names for this usecase and we can save a bit of memory and time.
Stacked on #89970 The staged rendering class will be used for more soon in more contexts (prod prerendering for runtime prefetches for example). This changes the interface for render abandonment to not use the presence of the render abort signal
If we don't explicitly return a `Vc::cell(())` here, then `<() as dyn turbo_tasks::vc::default::ValueDefault>::value_default` gets called in a non-deterministic way. That's not something we care about testing here, so just add a an explicit `Vc::cell(())` call to avoid it.
…les (#89976) ## Summary - update `installCompressedModuleFactories` to reuse an existing factory in a compressed ID group when filling missing IDs - keep `newModuleId` notifications aligned with actual IDs installed (`newModuleId(id)`) - add an execution regression test for the mixed-group case where one ID already has a factory and another is missing - regenerate affected runtime snapshots (runtime/debug-ids/workers/preset_env) Aims to fix cases like this being seen recently: ```sh Error: Module 8896 was instantiated because it was required from module 18500, but the module factory is not available. ``` ``` ## Test Plan - `cargo test -p turbopack-tests --test execution test_tests__execution__turbopack__runtime__factory_group_existing_factory__input__index_js -- --nocapture` - `cargo test -p turbopack-tests --test snapshot test_tests__snapshot__runtime__default_build_runtime__input__index_js -- --nocapture` - `cargo test -p turbopack-tests --test snapshot test_tests__snapshot__runtime__default_dev_runtime__input__index_js -- --nocapture` - `cargo test -p turbopack-tests --test snapshot test_tests__snapshot__debug_ids -- --nocapture` - `cargo test -p turbopack-tests --test snapshot test_tests__snapshot__swc_transforms__preset_env__input__index_js -- --nocapture` - `cargo test -p turbopack-tests --test snapshot test_tests__snapshot__workers__ -- --nocapture`
## Summary - pass `IncrementalCache` into the shared middleware template adapter so middleware/proxy modules initialize `globalThis.__incrementalCache` - add regression coverage for `unstable_cache` usage inside both deprecated `middleware` (edge) and `proxy` (node) fixtures - verify both e2e suites pass without hitting `Invariant: incrementalCache missing in unstable_cache` ## Verification - `pnpm build` - `NEXT_SKIP_ISOLATE=1 NEXT_TEST_MODE=dev pnpm testonly test/e2e/app-dir/app-middleware/app-middleware.test.ts` - `NEXT_SKIP_ISOLATE=1 NEXT_TEST_MODE=dev pnpm testonly test/e2e/app-dir/app-middleware-proxy/app-middleware-proxy.test.ts`
…ces (#89969) Follow-up for #89834. In `prerenderAndAbortInSequentialTasks`, React's `finishHalt` (scheduled via `setImmediate` from `abort()`) could race with the component's pending `setTimeout` callback. When both ended up in the same timer phase, the component timer would fire after `abort()` but before `finishHalt`, linking the async graph and producing the more precise `await` location (21:9). When `finishHalt` won the race, it read an unlinked graph and fell back to the function declaration (20:16). Adding `DANGEROUSLY_runPendingImmediatesAfterCurrentTask()` to the abort task captures `finishHalt` as a fast immediate, ensuring it runs right after `abort()` before any other timers. This makes the result deterministic at the cost of always producing the less precise stack frame (function declaration instead of `await` expression). The resolve step is split into a separate task because it needs to wait for the abort's fast immediates to complete. When using `--debug-prerender`, we're also re-adding the hint to run `next dev` for even better stack traces, since dev mode can produce the precise `await` location by running the render to completion and resolving the I/O promises. [Flakiness metric](https://app.datadoghq.com/ci/test/runs?query=test_level%3Atest%20%40git.repository.id%3A%22github.com%2Fvercel%2Fnext.js%22%20%40test.type%3A%22nextjs%22%20%40test.status%3A%22fail%22%20%40test.suite%3A%22Cache%20Components%20Errors%22%20%40git.branch%3Acanary%20-%40ci.pipeline.name%3Atest-e2e-deploy-release&agg_m=count&agg_m_source=base&agg_t=count¤tTab=overview&eventStack=&fromUser=false&index=citest&start=1770404554855&end=1771009354855&paused=false)
…89982) We don't need/want preview builds for these base branches, it's a waste of CI capacity. Relevant docs: https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#onpushbranchestagsbranches-ignoretags-ignore > Use the branches filter when you want to include branch name patterns or when you want to both include and exclude branch names patterns. Use the branches-ignore filter when you only want to exclude branch name patterns. You cannot use both the branches and branches-ignore filters for the same event in a workflow. > If you define only tags/tags-ignore or only branches/branches-ignore, the workflow won't run for events affecting the undefined Git ref. If you define neither tags/tags-ignore or branches/branches-ignore, the workflow will run for events affecting either branches or tags.
The second and third bullet points in the 'Good to know' callout were incorrectly placed outside the blockquote, breaking the visual grouping on the rendered documentation page. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> Co-authored-by: Andrew Damelio <andrewdamelio@users.noreply.github.com> Co-authored-by: Joseph <joseph.chamochumbi@vercel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )