[pull] canary from vercel:canary#788
Merged
pull[bot] merged 7 commits intocode:canaryfrom Feb 13, 2026
Merged
Conversation
Closes: https://linear.app/vercel/issue/DOC-5722/inlinecss-unclear-large-bundles-description --------- Co-authored-by: Allen Zhou <46854522+allenzhou101@users.noreply.github.com>
For some locations LightningCSS is 1-indexed (but not all of them, the rustdoc describes it though)
IssueSource is always 0-indexed
Previously, it looked like this
```
Error: Turbopack build failed with 1 errors:
./bench/basic-app/app/[variants]/styles.css:7:12
Module not found: Can't resolve './test1.png'
5 | .style {
6 | cursor: url(./test1.png);
> 7 | }
| ^
8 |
```
…set value (#89913) ## Summary - Add note that omitting `expire` in `cacheLife` results in cache never expiring - Fix `default` preset table: `expire` was documented as "1 year" but actual code uses `INFINITE_CACHE` (never) - Add mention of expire omission behavior in custom profiles section ## Why The `expire` property is optional (`expire?: number`), but the documentation didn't explain what happens when it's omitted. The source code shows it defaults to `INFINITE_CACHE` (0xfffffffe), meaning the cache never expires. Additionally, the preset profile table incorrectly listed the `default` profile's expire as "1 year" when the actual value is `INFINITE_CACHE`. ### Source code references - `packages/next/src/lib/constants.ts:45` — `INFINITE_CACHE = 0xfffffffe` - `packages/next/src/server/config-shared.ts:1580` — `default.expire: INFINITE_CACHE` - `packages/next/src/server/use-cache/cache-life.ts:156` — only sets `explicitExpire` when `expire !== undefined` - `packages/next/src/server/use-cache/use-cache-wrapper.ts:477-479` — falls back to `defaultCacheLife.expire` (INFINITE_CACHE) --------- Co-authored-by: Joseph <joseph.chamochumbi@vercel.com>
…on.svg) (#89504) ## What? Fixes a crash in Turbopack and incorrect behavior in Webpack when users have multiple icon files with the same base name but different extensions (e.g., `icon.png` and `icon.svg`) in their app directory. ## Why? This is a valid use case for browser fallback support - modern browsers can use SVG icons while older browsers (Safari <26) need to fall back to PNG. Previously: - **Turbopack**: Crashed during `next build` with "Dependency tracking is disabled so invalidation is not allowed" - **Webpack**: Silently ignored all but one format ## How? **Turbopack**: Changed virtual source filename from `{stem}--route-entry.js` to `{filename}--route-entry.js` (e.g., `icon.png--route-entry.js` and `icon.svg--route-entry.js`) to avoid file conflicts that triggered invalidation. **Webpack**: Changed `MetadataResolver` to return all matching files instead of just the first one. Both icon formats are now properly rendered: ```html <link rel="icon" type="image/png" sizes="114x114" href="/icon.png"> <link rel="icon" type="image/svg+xml" sizes="any" href="/icon.svg"> ``` Fixes #85496 Fixes NEXT-4816
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )