Conversation
…44667) # Why `BackgroundTaskWork.doWork()` catches `Exception` and converts it into `Result.failure()`. On the JVM, `CancellationException` is a subclass of `Exception`, so WorkManager coroutine cancellation can be swallowed by this generic catch block. When a running background task worker is cancelled, for example through `unregisterTask()` calling `stopWorker()`, the coroutine scope may throw `CancellationException` while waiting for task completion. Returning `Result.failure()` from that path incorrectly reports a cancelled worker as a failed worker. # How Catch `CancellationException` before the generic `Exception` handler, log that the worker was cancelled, and rethrow it. This preserves structured concurrency semantics and lets WorkManager handle the worker as stopped/cancelled instead of failed. # Test-plan - Verified the Android source compiles locally. - Confirmed the change only affects cancellation handling in `BackgroundTaskWork.doWork()`. - Confirmed generic task execution exceptions are still converted to `Result.failure()` with error output data. # Checklist - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
# Why Currently, the brownfield xcframework cannot be consumed by Objective-C. Without `DEFINES_MODULE = YES`, Xcode does not generate a Clang `module.modulemap` for the framework and the xcframework only ships with `.swiftmodule` interfaces. This causes: - `@import MyAppBrownfield;` to fail in ObjC files - `#import <MyAppBrownfield/MyAppBrownfield-Swift.h>` (the generated ObjC compatibility header) is not available The brownfield `ExpoBrownfield.podspec` already sets `DEFINES_MODULE = YES` for the pod target, but this setting was missing from the framework target created by the config plugin. # How Added `DEFINES_MODULE: '"YES"'` to the framework target's common build settings in `project.ts`. With this flag, Xcode auto-generates a `module.modulemap` for each architecture slice during the build, which `xcodebuild -create-xcframework` then includes in both the simulator and device slices of the xcframework. # Test Plan - Run `npx expo prebuild` and build the brownfield xcframework - Inspect the output: each slice should contain `Modules/module.modulemap` alongside the existing `Modules/<TargetName>.swiftmodule/` - Import the xcframework from an ObjC file with `@import MyAppBrownfield;` n # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )