Skip to content

Conversation

@Hisir0909
Copy link

@Hisir0909 Hisir0909 commented Jan 30, 2026

Summary

  • Ensures user-selected variant (ctrl+t / variant_cycle) is never overridden by plugin defaults, including on the first message of a new session
  • Makes auto-generated prompts (background task completion + atlas continuation) inherit the parent session’s variant for consistent reasoning level

Changes

  • keyword-detector: respect input.variant and use provider/model-aware ultrawork variant inference only as fallback
  • background-agent: include parent variant when sending completion notifications to the parent session
  • atlas: include parent variant when injecting boulder continuation prompts
  • index: centralize chat.message variant precedence logic to prevent first-message gate from overriding ctrl+t selection
  • tests: add coverage for variant precedence and inheritance scenarios

Testing

bun run typecheck
bun test

Related Issues

Closes #521


Summary by cubic

Respect the user-selected reasoning variant (Ctrl+T) across all messages and make auto-generated prompts inherit the parent session’s variant. Centralizes variant precedence to prevent defaults from overriding user choice and improves ultrawork variant inference.

  • Bug Fixes

    • Preserve input.variant on all chat messages, including the first in a new session.
    • Auto prompts (background task completion, atlas continuation) inherit the parent session’s variant.
    • Keyword detector respects input.variant and infers ultrawork variant by model/provider when unset.
  • Refactors

    • Centralized variant precedence in shared/chat-message-variant and applied it in index.
    • Added tests for variant precedence and inheritance across keyword-detector, atlas, and background-agent.

Written for commit e93525c. Summary will update on new commits.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2026

All contributors have signed the CLA. Thank you! ✅
Posted by the CLA Assistant Lite bot.

@Hisir0909
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 9 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

… prompts

- keyword-detector: use input.variant if provided, fallback to parent variant
- atlas: pass parent variant to auto-generated prompts for consistency
- background-agent: ensure variant precedence in provider-aware inference
- tests: add coverage for variant inheritance and precedence scenarios
…recedence

- extract variant precedence logic to chat-message-variant utility
- prevent firstMessageVariantGate from overriding user-selected variant
- ensure consistent variant handling across all message types
- tests: add coverage for variant precedence scenarios
@Hisir0909 Hisir0909 force-pushed the fix/variant-precedence branch from 374654c to e93525c Compare January 30, 2026 07:33
github-actions bot added a commit that referenced this pull request Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Option to disable forced thinking variant "max"

1 participant