feat(config): add fallback_models for model availability fallback #1237
+2,371
−227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b57fa36811
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
570
to
591
| const parsedModel = parseModelString(actualModel) | ||
| const variantToUse = userCategories?.[args.category]?.variant ?? resolvedVariant | ||
| categoryModel = parsedModel | ||
| ? (variantToUse ? { ...parsedModel, variant: variantToUse } : parsedModel) | ||
| : undefined | ||
| } | ||
| const variantToUse = resolved.config.variant ?? resolvedVariant | ||
| categoryModel = parsedModel |
There was a problem hiding this comment.
When a category has a default variant (e.g., ultrabrain → xhigh) and the fallback chain selects a different model with its own variant (e.g., Claude → max), this line now forces the default variant because resolved.config.variant is always populated from the category defaults. That overrides resolvedVariant and can send an invalid variant to the fallback provider, causing the delegated task to fail whenever the primary model is unavailable. The previous behavior only prioritized an explicit user override; consider reverting to user-only precedence or using resolvedVariant when the model came from the fallback chain.
Useful? React with 👍 / 👎.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
youming-ai
force-pushed
the
feat/fallback_models-restored
branch
from
8d2aff9 to
31107ce
Compare
youming-ai
added a commit
to youming-ai/oh-my-opencode
that referenced
this pull request
Jan 31, 2026
…el availability fallback Resolved conflicts in src/agents/utils.test.ts (import statements)
youming-ai
force-pushed
the
feat/fallback_models-restored
branch
from
2653c86 to
de8f283
Compare
Allow agents and categories to specify fallback models when the preferred model is unavailable, and surface the option in schema/docs/tests.
…and update test expectations Fix two issues with fallback_models feature: - Update test expectations in model-resolver.test.ts to match actual log message format - Fix applyCategoryOverride to not overwrite model when it was already resolved via fallback_models - Ensures category config properly respects the resolved model from fallback chain Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <[email protected]>
youming-ai
force-pushed
the
feat/fallback_models-restored
branch
from
de8f283 to
056734f
Compare
Fix comment numbering inconsistency in model resolution pipeline: - Step 1: UI Selection - Step 2: Config Override - Step 3: User-configured fallback_models (was 1.5) - Step 4: Category Default Model (was 2.5) - Step 5: Provider fallback chain (was 3, with substeps 5.1/5.2) - Step 6: System default (was 4) Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <[email protected]>
Add tests for edge cases in fallback_models feature: - Empty fallback_models array preserves override semantics - Duplicate entries in fallback_models are correctly deduplicated Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <[email protected]>
…rors Add runtime_fallback feature that automatically switches to fallback models when API errors occur: - Intercepts session.error events with retryable status codes (429, 503, 529) - Supports fallback_models from agent/category configuration - Respects cooldown periods and max fallback attempts - Shows toast notifications when fallback occurs - Comprehensive test coverage (18 tests) Configuration options: - enabled: boolean (default true) - retry_on_errors: number[] (default [429, 503, 529]) - max_fallback_attempts: number (default 3) - cooldown_seconds: number (default 60) - notify_on_fallback: boolean (default true) Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <[email protected]>
Update documentation to reflect the completed runtime_fallback feature: - configurations.md: Remove 'planned' note, add detailed usage instructions - RFC-runtime-model-fallback.md: Mark as IMPLEMENTED with 18 passing tests - Add implementation notes and architecture details - Document resolved questions and key design decisions Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds a
fallback_modelsconfig option (string | string[]) so agents/categories can select the first available model at initialization time when the preferred model is unavailable.Why
Provider connectivity and model availability vary across environments. This reduces brittle startup behavior when a single configured model cannot be used.
Changes
fallback_modelsto agent overrides and category config schema.fallback_models(viaavailableModelsor connected-providers cache) before built-in fallback chain and system default.resolvedModelis not overwritten byoverride.model.override.category.Notes
Verification
bun run typecheckbun test src/shared/model-resolver.test.ts src/agents/utils.test.ts