Skip to content

fix: handle repos without git gracefully #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2025
Merged

Conversation

BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Apr 1, 2025

This error:

Error: fatal: not a git repository (or any of the parent directories): .git

occurred while executing code-pushup code in a MCP server. But in general we should not throw an error if someone executes the tool without git.

Copy link

github-actions bot commented Apr 1, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 6587e4e with previous commit 137392e.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 47 🔴 48 ↑ +1.3
Code coverage 🟢 90 🟢 90 ↓ −0.1
Security 🟡 62 🟡 62
Updates 🟡 84 🟡 84
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Type Safety 🟢 100 🟢 100
Bug prevention 🟢 100 🟢 100
Miscellaneous 🟢 100 🟢 100
Code style 🟢 100 🟢 100
Documentation 🔴 23 🔴 23
👍 1 group improved, 👎 1 group regressed, 👍 3 audits improved, 👎 4 audits regressed, 10 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 47 🔴 48 ↑ +1.3
Code coverage Code coverage metrics 🟢 90 🟢 90 ↓ −0.1

19 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Speed Index 🟥 8.3 s 🟥 6.0 s ↓ −27.9 %
Lighthouse Time to Interactive 🟥 15.9 s 🟥 12.9 s ↓ −19 %
Lighthouse Largest Contentful Paint 🟨 3.7 s 🟨 3.9 s ↑ +6.5 %
Lighthouse First Contentful Paint 🟨 2.9 s 🟨 2.9 s ↑ +0.4 %
Lighthouse Total Blocking Time 🟥 7,780 ms 🟥 3,710 ms ↓ −52.4 %
Code coverage Branch coverage 🟨 86 % 🟨 85.9 % ↓ −0.1 %
Code coverage Line coverage 🟨 89.8 % 🟨 89.8 % ↓ −0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,838 KiB 🟩 Total size was 1,831 KiB ↓ −0.4 %
Lighthouse Minimizes main-thread work 🟥 22.1 s 🟥 15.1 s ↓ −31.6 %
Lighthouse JavaScript execution time 🟥 10.0 s 🟥 6.5 s ↓ −34.8 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −19 %
Lighthouse Max Potential First Input Delay 🟥 3,290 ms 🟥 1,940 ms ↓ −40.9 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 210 ms 🟥 Potential savings of 1,060 ms ↑ +397.2 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↑ +0.1 %
Lighthouse Initial server response time was short 🟩 Root document took 560 ms 🟩 Root document took 380 ms ↓ −33.1 %
Lighthouse Server Backend Latencies 🟩 260 ms 🟩 100 ms ↓ −61.3 %
Lighthouse Network Round Trip Times 🟩 80 ms 🟩 50 ms ↓ −37.7 %

586 other audits are unchanged.

@BioPhoton BioPhoton marked this pull request as ready for review April 1, 2025 17:59
@BioPhoton BioPhoton requested a review from matejchalk April 1, 2025 18:05
@matejchalk matejchalk merged commit 18225ed into main Apr 9, 2025
16 of 17 checks passed
@matejchalk matejchalk deleted the handle-non-git-repos branch April 9, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants