Skip to content

Commit 4266e06

Browse files
authored
Add step to number setting inputbox (microsoft#167093)
Fixes microsoft#166897
1 parent 6333552 commit 4266e06

File tree

2 files changed

+9
-0
lines changed

2 files changed

+9
-0
lines changed

src/vs/base/browser/ui/inputbox/inputBox.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -265,6 +265,14 @@ export class InputBox extends Widget {
265265
}
266266
}
267267

268+
public get step(): string {
269+
return this.input.step;
270+
}
271+
272+
public set step(newValue: string) {
273+
this.input.step = newValue;
274+
}
275+
268276
public get height(): number {
269277
return typeof this.cachedHeight === 'number' ? this.cachedHeight : dom.getTotalHeight(this.element);
270278
}

src/vs/workbench/contrib/preferences/browser/settingsTree.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1758,6 +1758,7 @@ export class SettingNumberRenderer extends AbstractSettingRenderer implements IT
17581758

17591759
template.onChange = undefined;
17601760
template.inputBox.value = dataElement.value;
1761+
template.inputBox.step = dataElement.valueType.includes('integer') ? '1' : 'any';
17611762
template.inputBox.setAriaLabel(dataElement.setting.key);
17621763
template.onChange = value => {
17631764
if (!renderValidations(dataElement, template, false)) {

0 commit comments

Comments
 (0)