Fix text to speech and lesson extras not showing in advanced settings when creating a section #66872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nokondi
requested review from
a team and
lfryemason
and removed request for
a team
Nokondi
commented
Jul 2, 2025
| // - sections: list of objects that represent the sections to create | ||
| // - updateSection: function to update the section at the given index | ||
| // - batchUpdateSection: function to update multiple section properties at once |
There was a problem hiding this comment.
I had forgotten to update the comments here when I added the batchUpdateSection method.
There was a problem hiding this comment.
Thanks for adding this now!
lfryemason
approved these changes
Jul 2, 2025
| // - sections: list of objects that represent the sections to create | ||
| // - updateSection: function to update the section at the given index | ||
| // - batchUpdateSection: function to update multiple section properties at once |
There was a problem hiding this comment.
Thanks for adding this now!
Nokondi
deleted the
fix-mismatch-between-advanced-settings-toggle-when-creating-or-editing-section
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an error preventing two advanced section options (text to speech and lesson extras) from showing on the section edit page when creating a new section. This was because the booleans that determine whether to display these options would only be set if the course selected was a standalone unit. This update removes the standalone unit check so that the options will display for any course that allows for text to speech or includes lesson extras.
Links
TEACH-1917
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: