Skip to content

Move email nil behavior from GitHub.Adapters.User to Account.create_from_github #996

Description

@begedin

Problem

At the moment, our github user adapter specifically removes the email key if the value in the github payload is nil. The reasoning behind it is that we do not want to unset the user email from github.

However, this is an "input" validation issue and should not be part of the behavior of an adapter. Instead, it should go into the github user changeset in Accounts.create_from_github

The tests should follow suit as well.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions