Skip to content

Add fallback for GitHub avatars when async processing #1017

Description

@joshsmith

Problem

For the fallback:

  • Rewrites the cloudinary_image/5 fn signature to accept the User's github_avatar_url in addition to the cloudinary_public_id
  • In CloudinaryUrl.for/5, pattern match on the presence of a github_avatar_url in order to instead use the GitHub avatar URL as a fallback (with the right sizing options)
  • Test the ImagePresenter and CloudinaryUrl modules accordingly

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions